Feature: Upload external resources#1492
Merged
Conversation
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
force-pushed
the
feature/upload-external-resources
branch
from
1907b71 to
f814ab3
Compare
AaronPlave
reviewed
Oct 21, 2024
AaronPlave
reviewed
Oct 21, 2024
AaronPlave
reviewed
Oct 21, 2024
AaronPlave
reviewed
Oct 21, 2024
Collaborator
Author
|
@AaronPlave should be ready for another look at. Thanks! |
duranb
force-pushed
the
feature/upload-external-resources
branch
from
867580f to
d5ad438
Compare
AaronPlave
reviewed
Oct 21, 2024
AaronPlave
reviewed
Oct 21, 2024
AaronPlave
reviewed
Oct 21, 2024
duranb
force-pushed
the
feature/upload-external-resources
branch
from
d5ad438 to
86bdcbf
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
approved these changes
Oct 22, 2024
fix unique list of types
duranb
force-pushed
the
feature/upload-external-resources
branch
from
67354e3 to
86df418
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
Collaborator
|
Tested locally with the gateway PR which has merged - merging this for release. Thanks! |
dandelany
pushed a commit
that referenced
this pull request
Aug 14, 2025
* fix collapse clickthrough * move scheduling enum file to enums directory * Add ability to upload external dataset to plan * add ability to associate simulation dataset to external datasets * styling * add e2e tests for dataset uploading * update design * add toasts for external dataset upload * cleanup * ensure unique resource name * add styling * fix unique profile names * fix styling fix unique list of types * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
___REQUIRES_GATEWAY_PR___="112"Partially resolves: #1424
To test:
/e2e-test/data/external-dataset.json/e2e-test/data/external-dataset.csvfile